rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

How about moving `wasm-timer` into the rust-libp2p/misc ?

Open koushiro opened this issue 2 years ago • 4 comments

How about moving wasm-timer into the rust-libp2p/misc dir, like #2641 did.

/cc @mxinden @tomaka

koushiro avatar May 17 '22 05:05 koushiro

Maybe quicksink also needs to be moved to the misc dir?

koushiro avatar May 17 '22 06:05 koushiro

How about moving wasm-timer into the rust-libp2p/misc dir

I would much rather like to see it replaced with a timing library that is still actively maintained. See https://github.com/libp2p/rust-libp2p/issues/2497#issuecomment-1038923700. Contributions would be very much appreciated.

Maybe quicksink also needs to be moved to the misc dir?

Any particular reason for that?


In general, while I am a big fan of mono-repos, I would like to:

  • Keep things useful (and used) outside of libp2p outside the monorepo.
  • Ideally reduce the maintenance work on the rust-libp2p maintainers rather than increasing it.

mxinden avatar May 18 '22 08:05 mxinden

Maybe quicksink also needs to be moved to the misc dir?

Any particular reason for that?

quicksink is used for libp2p-websocket, but this repo has been archived by paritytech.

I'm not sure if there is an alternative of this library.

koushiro avatar May 18 '22 09:05 koushiro

Instead of moving another generic library into the rust-libp2p monorepo, I think we can replace the use of quicksink in libp2p-websocket instead. Not a strong opinion, though would prefer not increasing the maintenance work on us long term.

mxinden avatar May 22 '22 16:05 mxinden

I'll close this as not planned. wasm-timer is unmaintained and we are moving away from it in https://github.com/libp2p/rust-libp2p/pull/3973 at least for gossipsub.

thomaseizinger avatar May 23 '23 16:05 thomaseizinger