Max Inden
Max Inden
> [flatten StreamMuxer interface](https://github.com/libp2p/rust-libp2p/pull/2622/commits/cf2c11d213a3aba40faf92f5c9aa2c433399073a) Thanks for adjusting to the change so quickly. //CC @thomaseizinger to see your change in action on a different transport.
> @mxinden maybe you know ^? @melekes I got a mail notification for the comment above, though I am unable to find it and thus read its context. Please tag...
I am sorry for not being very responsive here. I will focus on this tomorrow.
Following up on https://github.com/libp2p/rust-libp2p/pull/2622#discussion_r936754137 and whether `Connection` needs `pin_project`. I think you only need to implement `Unpin` for Connection. See https://github.com/melekes/rust-libp2p/pull/2 @melekes .
For the record, in case we go with the message framing proposal (https://github.com/mxinden/specs/pull/1), a first implementation of it can be found here: https://github.com/mxinden/rust-libp2p/tree/webrtc-message-framing
Does your protocol name start with a `/` @laptou? See: https://github.com/libp2p/rust-libp2p/blob/e19391e966d64aad1839aa7781a275c64100c75a/misc/multistream-select/src/protocol.rs#L82-L87
> I can whip up a PR to document this requirement :rocket: I would suggest documenting it on `Protocol`: https://github.com/libp2p/rust-libp2p/blob/5617481e56e3949dabc7ead26f15a75c0f50136f/misc/multistream-select/src/protocol.rs#L69-L71 and linking to `Protocol` in https://github.com/libp2p/rust-libp2p/blob/5617481e56e3949dabc7ead26f15a75c0f50136f/protocols/kad/src/behaviour.rs#L218-L226
@laptou friendly ping. Would you still be up for documenting this?
Thanks for the report. https://github.com/tokio-rs/console might help here debugging the issue. Help greatly appreciated.
@ddeguglielmo with the latest changes to `libp2p-mdns` does the above issue still persist?