Max Inden

Results 900 comments of Max Inden

> All my alternative solutions lead to having Arc which is very similar to Family :) As you likely know, you can implement your own metrics, e.g. in this particular...

I am still hesitant to expose these internals for the sake of testing downstream logic. Increasing the API surface of this library makes it harder to maintain in the future....

> `/memory` is useful for testing protocols which do not depend on specific remote or local addresses but it cannot be used for testing something like AutoNATv2 without changing the...

rust-libp2p's `/webrtc-direct` implementation reuses the listen port for outgoing dials. Related: currently rust-libp2p's `/webrtc-direct` implementation has a bug, where one can not dial without a previous listen. https://github.com/libp2p/rust-libp2p/issues/4071

> Possibly not having observed public IPv6 addrs to exchange, which breaks everything Extending this. Nodes need to discover their public IP address via identify and validate them via AutoNAT....

> Hard-code some well known servers ? (bad, not local first) I don't have a good solution here. I would start with this, i.e. I would start with a hard-coded...

Implemented through https://github.com/prometheus/client_rust/pull/82. Let me know what you think. Closing here.

@palash25 #105 introduced a fairly large change. I am sorry for the conflict. Let me know in case you need any help updating.

> Before I dive deeper into the implementation of Summary, can you expand on why you chose CKMS and how it differs to the [golang implementation](https://github.com/prometheus/client_golang/blob/main/prometheus/summary.go)? @beorn7 given that you...

@chylex thanks for reporting here. In general, yes I am in favor of checking proper formatting of labels in debug mode. In your particular case, I am guessing that you...