Max Inden
Max Inden
@stanislav-tkach that is correct, there is no way to use rust-libp2p without protoc/protobuf as of today. `PeerId` are at the core of libp2p. `PeerId`s are encoded via Protobuf. Thus we...
> I'm using ping to keep connections alive, that may be the cause of the observed behavior. Do I understand correctly that you are setting `PingConfig::with_keep_alive(true)` @hamamo? https://github.com/libp2p/rust-libp2p/blob/2ff9acee227bc8787fb41d657de5f174250e2588/protocols/ping/src/handler.rs#L52-L54 > Since...
> So if a mesh is established but not permanently used it does not seem to keep connections alive That is surprising to me. Once a peer joins a mesh,...
Just a wild guess, seeing logic in `reputation_net/mod.rs` related to awaiting storage operations within the custom `NetworkBehaviour`. Do these operations block the main libp2p task for longer period of time?...
Mind splitting the PR in two? https://github.com/libp2p/rust-libp2p/pull/2536/commits/0c5fa28b5a97276cb4ccbb9335b6588253d551e7 we can merge soon. https://github.com/libp2p/rust-libp2p/pull/2536/commits/88cc599dfde60cecc06dd827dfc1add4c1be54ef I want to give a bit more thought.
@melekes Thank you very much for this pull request. Exciting work! I won't get to reviewing it this week, though I will make sure I come back to it next...
> Most importantly, I think from an overall design perspective, we should try and avoid these long-running tasks that are just spawned into the executor. The rest of rust-libp2p is...
@melekes does it make sense for me to give this another review? Or would you prefer to wait until after this is updated to the latest `Transport` and `StreamMuxer` changes?...
> Kinda wish there was a document with changes that must be made to the transport. Sorry for not providing anything beyond the changelogs. I can either answer questions here,...
Running the `smoke` test I get the following error thrown by `Swarm` `b`: ``` [2022-07-12T11:09:01Z DEBUG libp2p_swarm] Connection attempt to PeerId("12D3KooWKbEiAmPbGGK4gzXJVMVgX3DVsdubgDAiQimBo7m96r3B") failed with Tra nsport([("/ip4/127.0.0.1/udp/36016/x-webrtc/9AEE8750F3BAEB7CD2E2DF76EE265F199573FC8D415A570B774439ECDDC74837/p2p/12D3KooWKbEiAmPbGGK4gzXJVMVgX 3DVsdubgDAiQimBo7m96r3B", Other(Custom { kind: Other,...