Max Inden

Or potentially due to https://github.com/libp2p/rust-libp2p/pull/2720, as that imports another `libp2p-core` version which is incompatible.

> Or potentially due to #2720, as that imports another `libp2p-core` version which is incompatible. Unfortunately, this is not the case. Merged #2720 and updated here with latest `master`. Still...

I am out of ideas :/ Maybe worth involving the developers of rust-semverver here?

Sounds good to me. Also, should we be using `either::Either` or `futures::future::Either` or both?

> Change default for `event_process` to `true` instead of `false`. User that would like to keep using it would have to explicitly add `#[event_process=false]` rather than it being the default...

@elenaf9 @thomaseizinger with https://github.com/libp2p/rust-libp2p/pull/2792 merged, would you mind taking another look?

> One more thing: I think if we are deprecating `NetworkBehaviourEventProcess` we should also already change our examples & tests to not use it anymore (`examples/distributed-key-value-store.rs`, `examples/chat.rs`, ...). Can be...

As far as I can tell all comments are addressed and everyone approved. Thus I am merging here. Happy to do any follow-ups in case I missed something. As always,...

> [2022-06-25T15:54:27Z DEBUG libp2p_dns] Dial error: MultiaddrNotSupported("/p2p/12D3KooWDpJ7As7BWAwRMfu1VU2WCqNjvq387JEYKDBj4kx6nXTN/p2p/12D3KooWH3uVF6wv47WnArKHk5p6cvgCJEb74UTmxztmQDc298L3"). This is now fixed with https://github.com/libp2p/rust-libp2p/issues/2696.

> `[2022-06-25T15:56:39Z DEBUG libp2p_dns] Dial error: Transport(Os { code: 110, kind: TimedOut, message: "Connection timed out" }).` This is the relevant part. The listener tried to do a coordinated upgrade,...