Max Inden

Related issue on `if-watch` used in `libp2p-mdns`: https://github.com/mxinden/if-watch/issues/21 //CC @dignifiedquire

Thanks @gallegogt for the thorough patch and thanks @thomaseizinger for the detailed reviews!

@gallegogt let us know once this is ready for another review.

Failing on my machine as well: ``` ➜ cargo test --all-features Finished test [unoptimized + debuginfo] target(s) in 0.17s Running unittests src/lib.rs (/home/mxinden/code/github.com/libp2p/rust-libp2p/target/debug/deps/libp2p_mdns-aeea3dee3d0f3ca4) running 5 tests test behaviour::iface::dns::tests::build_service_discovery_response_correct ... ok...

> Very rare situation, I guess tokio (explicitly non_blocking) takes longer to find the peers than AsynIO. If so, I increase the expiration time and query request a little That...

Great bug report @mental32. Very much appreciate the level of detail. > Ask the transport for an executor during SwarmBuilder::build so tokio transports can produce a well-configured executor and the...

We might want to consider not using a [`ThreadPool`](https://docs.rs/futures/latest/futures/executor/struct.ThreadPool.html) in `SwarmBuilder::build`: https://github.com/libp2p/rust-libp2p/blob/6cc3b4ec52c922bfcf562a29b5805c3150e37c75/swarm/src/lib.rs#L1335-L1348 We could instead use a [`LocalPool`](https://docs.rs/futures/latest/futures/executor/struct.LocalPool.html) instead. While, obviously, this would hurt default performance, if I am not...

@divagant-martian or @AgeManning might be able to help here.

I am not sure why the new CI step is failing, any ideas? ``` version bump: 0.45.0 -> (breaking) -> 0.45.1 error: breaking changes in `development_transport` --> /home/runner/work/rust-libp2p/rust-libp2p/src/lib.rs:200:1 | 200...

Thanks for digging into this once more @maschad. > My only hypothesis right now is that [245b056#diff-4ef9da87778def7bb67a144d06f9cc429d901994dd8b054812c14c1dac2b0df6R76-R78](https://github.com/libp2p/rust-libp2p/commit/245b0563ab41a37b52d1d45ddb59f8706e130a53#diff-4ef9da87778def7bb67a144d06f9cc429d901994dd8b054812c14c1dac2b0df6R76-R78) introduced a new field and based on the current RFC [adding new fields...