Max Inden

Results 899 comments of Max Inden

Wonderful work @vincev. Thanks for the elaborate `README.md`. > Keep in mind that I didn't do any serious testing, this is more of a proof of concept to test libp2p...

@kpp @tomaka do you have thoughts on this? This will require a small change in the _Authority Discovery_ module. @koivunej what do you think of this proposal? I would guess...

> > This will require a small change in the Authority Discovery module. > > I am not sure how many changes this will require. I looked through the code...

@dignifiedquire let me know once this is ready for another review. Excited for this to eventually land.

> @mxinden if we remove the quorum from `get_record`, is your expectation that there is no termination condition anymore, and the caller always has to manually terminate, or should there...

Friendly ping @dignifiedquire. Would be unfortunate for this to go stale. Anything you would need from my end? Do I understand correctly, that this is the only reason why iroh...

> Honestly I am not sure how much sense it really makes to change the others behaviour atm, other than the changes I made so far. Do you see any...

> > If I am not mistaken, from a high level, only `FindNode` is missing > > I am not sure exactly which public facing api you are referring to...

Hope to get a full review done tomorrow. That way you don't have to follow up on many (small) comments, but instead one large batch.

@dignifiedquire please don't force push on rust-libp2p pull requests. In particular this makes collaborating on a pull request hard. We squash-merge, thus a clean commit history, while appreciated, isn't necessary.