Max Inden

Results 899 comments of Max Inden

> > > Nice idea but it won't allow us to enforce invariants, right? > > > > > > True. Would be great to enforce these at runtime. Would...

> To progress on this issue, would it be okay to transition all/most usages to std types like `&static [u8]` and `String`? I am fine with that.

I think the following order makes most sense: 1. #2831 2. Move `ProtocolName` to `String` 3. Do the actual change here, namely to use `Either` That said, I don't think...

> Is there official spec written somewhere? Spec: https://github.com/ipfs/specs/blob/master/BITSWAP.md https://github.com/ipfs/specs/pull/269 and https://github.com/ipfs/specs/pull/270 > Do we start from scratch or modify one of the existing implementations? I would have to review...

@SionoiS you raised in the last community call that you would be interested in working on this, supported through a grant :tada:. What would be the timeline on your end?...

> OR if it's ok with PL I could work on both at the same time but it's going to take longer. I would prefer doing the two in sequence...

Oh, surprising. Thanks for the debugging work and the detailed report @AgeManning and @divagant-martian! > It would be nice to get the current implementation to work correctly and be as...

https://github.com/libp2p/rust-libp2p/pull/2506 is merged. I will leave this issue open to track support for `wasm-unknown-unknown` for `libp2p-gossipsub`. **Next step** I think it is worth exploring contributing an `Interval` implementation to `futures-timer`...

Corresponding pull request on the Golang side: https://github.com/libp2p/go-libp2p/pull/1663

Thanks for documenting this! > Maybe @mxinden you can also give some input here as the original author of the relay_v2 protocol. I am in favor of the above suggestion....