Max Inden
Max Inden
> Unfortunately the AlertManager API documentation is poor vs Prometheus Server API documentation. See link below: https://prometheus.io/docs/alerting/management_api/ This only documents the API documentation. Given that you stumbled over it, it...
I don't have much experience with amtool. In addition as this would be a usage question the mailing list is the best place to ask https://groups.google.com/forum/#!forum/prometheus-users.
Friendly ping @mriise. Does this issue still persist?
> The motivation for this question is that as part of the listener refactoring in #2652 and [elenaf9#4](https://github.com/elenaf9/rust-libp2p/pull/4), "remembering" the ws / wss protocol for inner listeners gets more complicated....
> In [swarm/src/connection/pool/task.rs:240](https://github.com/libp2p/rust-libp2p/blob/master/swarm/src/connection/pool/task.rs#L240) the call to the future closing_muxer is missing, If I recall correctly, the reasoning why `_closing_muxer` is not `await`ed is, that in this case an error happened...
> If you don't close the connection how can a transport layer be notified in case of error ? In this case it is the transport layer notifying the muxer...
Thanks for debugging. @elenaf9 can you expand on how this is handled in https://github.com/libp2p/rust-libp2p/pull/2289?
@elenaf9 thanks for the quick and detailed response. @pj50 do you have some time to validate the above patches with https://github.com/libp2p/rust-libp2p/pull/2289?
> It's the usual practice to commit `.lock` files in JS and [Haskell](https://docs.haskellstack.org/en/stable/lock_files/). But in Rust, Cargo book suggests against it for library authors. And it makes little sense to...
> @mxinden anything else I can do to merge this PR? I still don't understand why you need to configure this flag. Can you expand on that once more? I...