Max Duval comments

Results 33 comments of


Max Duval

Convert `detect.js` to TypeScript

We’ve done something a little different tackling a specific part of `detect` before, specifically `detect-viewport`: - #24443

Fronts Ophan tag parity (`data-link-name`)

Varying webpack bundles for tests

Deployed on CODE and saw the assets come through as expected

Fronts Ophan tag parity (`data-component`)

All the missing components/containers/elements are not yet implemented in DCR Fronts: - `contact-the-guardian`: This is the `Tip us off` banner - `labs-container-12`: This is the Guardian Labs container. In Frontend,...

Scala 2.12 -> 2.13

Fixed by #25190

Add TSDoc types

Hey @lukeed, anything I can do to help push this over the line?

Adding types for `webpack-messages`

Brilliant, will do. Shout-out to @sndrs for suggesting we push our definition upstream.

Possibility of Typescript support

Just wanted to chime in and say that we have partial types for Prebid, based off the documentation, and that can be seen as a [WIP here](https://github.com/guardian/frontend/blob/3229766aafbe649287ecd2c29202f62f4cbf8884/static/src/javascripts/projects/commercial/modules/header-bidding/prebid/prebid.ts) I would be...

Warehouse test - Part 3: Commands should be NE, SW etc.

Part three states (emphasis mine): > We have expanded the robot's grid system to include diagonal tracks. Modify the robot's movement so that it can take advantage of the new...