Max Duval

Results 33 comments of Max Duval

An alternative to using `Picture` is creating a component specifically for fronts: `FrontPicture` introduced in #6065

Realised that this will not work because the tests are not named properly. The following two PRs should fix it - #6168 - https://github.com/guardian/frontend/pull/25578

So far, [no new kinds of errors have shown up in Sentry](https://sentry.io/organizations/the-guardian/issues/?project=1377847&query=is%3Aunresolved+dcr.bundle%3AdcrJavascriptBundleVariant&statsPeriod=14d).

We can roll this out to everyone, as we got this from Guy, our data analyst: > Just checked and no notable or significant difference between the control and variant...

> Will we be bumping the AR and DCR AMIgo recipes too? > – @JamieB-gu I have already updated the DCR one. Do you want me to update the AR...

> Following the discussion in last week's Client Side Infra, should we consider a bump to 16 instead? > – @georgeblahblah I have attempted to do this in #5577, but...

It looks that this has prevented the `Typescript` and `TeamCity`… which means that we have no way of testing this PR against our CI/CD pipeline.

As suggested by @akash1810, we managed to [run this in TeamCity](https://teamcity.gutools.co.uk/buildConfiguration/dotcom_master/817060) with the following [script from Grid](https://github.com/guardian/grid/wiki/Testing-third-party-contributions): ```sh #!/usr/bin/env bash set -e if [ -z $1 ] then echo "Please...

> Maybe we can hoist the `sellByDate` to an `Experiment`? I think this can be addressed into another PR. I’m not entirely sure how hoisting works in Scala, so let’s...

We had a specific use case where we needed this to work, and it’s possible to [turn this into an ES Module by stripping away a few things](https://raw.githubusercontent.com/guardian/csnx/ddfb37704a82df524ac2407d77544f73f3d38c6a/apps/ua-parsing/src/ua-parser.js). I would...