frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Published 20 hours ago • verified publisher icon guardian

Convert `detect.js` to TypeScript

Open chrislomaxjones opened this issue 2 years ago • 4 comments

What does this change?

TODO

Does this change need to be reproduced in dotcom-rendering ?

  • [X] No
  • [ ] Yes (please indicate your plans for DCR Implementation)

What is the value of this and can you measure success?

TODO

Tested

  • [ ] Locally
  • [ ] On CODE (optional)

chrislomaxjones avatar May 25 '22 16:05 chrislomaxjones

We’ve done something a little different tackling a specific part of detect before, specifically detect-viewport:

  • #24443

mxdvl avatar May 26 '22 15:05 mxdvl

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

github-actions[bot] avatar Jul 14 '22 06:07 github-actions[bot]

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

github-actions[bot] avatar Aug 15 '22 06:08 github-actions[bot]

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

github-actions[bot] avatar Sep 15 '22 06:09 github-actions[bot]

@chrislomaxjones still working on this?

Jakeii avatar Oct 13 '22 11:10 Jakeii

@Jakeii I haven't touched it since opening the PR. Feel free to take it from here if you've got an eye on it 🙂

chrislomaxjones avatar Oct 13 '22 16:10 chrislomaxjones

Closing in favour of #25601

Jakeii avatar Oct 21 '22 10:10 Jakeii