dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

Fronts Ophan tag parity (`data-component`)

Open mxdvl opened this issue 2 years ago • 2 comments

Remaining Front components mismatches

Comparing data-component on the international Front between Frontend & DCR.

Missing from DCR (3 / 22)

  • [ ] palette-styles-new-do-not-delete<section/>
  • [ ] video-playlist<div/>
  • [ ] trending-topics<section/>

Tag mismatch (2 / 22)

  • [X] nav2 : <div /> ✗ should be → <nav/>
  • [X] footer : <div /> ✗ should be → <footer/>

Identical match (17 / 22)

  • [X] ukraine-invasion<section/>
  • [X] headlines<section/>
  • [X] spotlight<section/>
  • [X] climate-crisis<section/>
  • [X] opinion<section/>
  • [X] sport<section/>
  • [X] around-the-world<section/>
  • [X] documentaries<section/>
  • [X] contact-the-guardian<section/>
  • [X] culture<section/>
  • [X] lifestyle<section/>
  • [X] explore<section/>
  • [X] take-part<section/>
  • [X] today-in-focus<section/>
  • [X] videos<section/>
  • [X] in-pictures<section/>
  • [X] most-viewed<section/>

mxdvl avatar Apr 22 '22 10:04 mxdvl

See also #4662

mxdvl avatar Apr 22 '22 11:04 mxdvl

All the missing components/containers/elements are not yet implemented in DCR Fronts:

  • contact-the-guardian: This is the Tip us off banner image

  • labs-container-12: This is the Guardian Labs container. In Frontend, the naming is always based on whether this is a paid container. image

  • video-playlist: maybe this is "fixed/video" image

  • trending-topics: List of topics at the bottom of Front image

  • footer: Missing from now image

mxdvl avatar May 03 '22 10:05 mxdvl

review at and after launch

VDuczekW avatar Dec 19 '22 15:12 VDuczekW

#4692

rhiannareechaye avatar Jun 12 '23 13:06 rhiannareechaye

Completed

ioannakok avatar Jun 28 '23 09:06 ioannakok