Max Duval

Results 33 comments of Max Duval

cc. @guardian/commercial-dev

Hi there @mchv! Should this PR remain open? It's been around for a while and should probably either ship or be closed. If it needs to remain open, could you...

Excellent work with @DanielCliftonGuardian, @OllysCoding and @AshCorr meant we fixed the all the Youtube iframe titles in one fell swoop!

@jlieb10 are you referring to the `data-link-name` and `data-component` attributes? These are added automatically to `ContainerLayout` and `Card`.

See test cleanup PR [frontend#23665](https://github.com/guardian/frontend/pull/23665)

This seems valuable, will you be merging it, @dblatcher?

> So we decided to be safe to use the same key, and add the additional expiry logic here based on both the value and the expiry functionality. So that...

This looks like a bug, as the following are working as expected even if signed-in: - https://www.theguardian.com/guardian-labs - https://www.theguardian.com/guardian-labs-us ![comparing guardian labs](https://user-images.githubusercontent.com/76776/173328865-b4b37677-a7ad-48ab-b0a9-b91747a77d29.png)

Ongoing research to identify why the paid containers are skipped for this page. Potential areas of interest are : - https://github.com/guardian/frontend/blob/main/common/app/views/fragments/containers/facia_cards/container.scala.html#L30 - https://github.com/guardian/frontend/blob/main/common/app/layout/FaciaContainer.scala#L163-L166 - https://github.com/guardian/frontend/blob/main/common/app/model/facia/PressedCollection.scala#L37-L43

Some work has gone into catching errors, and we now stand at 249 errors only. Most of them come from arrays of unknown length in Front slices. See also: -...