dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

Fronts Ophan tag parity (`data-link-name`)

Open mxdvl opened this issue 2 years ago • 1 comments

Remaining Front components mismatches

Comparing data-link-name on the international Front between Frontend & DCR.

Missing from DCR (115 / 263)

  • [ ] skip : main content<a/>
  • [ ] nav2 : supporter-cta<a/>
  • [ ] nav2 : topbar: my account<input/>
  • [ ] nav2 : topbar : account overview<a/>
  • [ ] nav2 : topbar : billing<a/>
  • [ ] nav2 : topbar : profile<a/>
  • [ ] nav2 : topbar : email prefs<a/>
  • [ ] nav2 : topbar : settings<a/>
  • [ ] nav2 : topbar : help<a/>
  • [ ] nav2 : topbar : comment activity<a/>
  • [ ] nav2 : topbar : sign out<a/>
  • [ ] nav2 : topbar : edition-picker: toggle<input/>
  • [ ] nav2 : topnav : edition-picker: toggle<label/>
  • [ ] nav2 : veggie-burger : show<input/>
  • [ ] nav2 : overlay<label/>
  • [ ] nav2 : secondary : News<button/>
  • [ ] nav2 : secondary : Opinion<button/>
  • [ ] nav2 : secondary : Sport<button/>
  • [ ] nav2 : secondary : Culture<button/>
  • [ ] nav2 : secondary : Lifestyle<button/>
  • [ ] nav2 : edition picker<button/>
  • [ ] nav2 : edition-picker: UK<a/>
  • [ ] nav2 : edition-picker: AU<a/>
  • [ ] nav2 : edition-picker: INT<a/>
  • [ ] nav2 : subnav : US news<a/>
  • [ ] nav2 : subnav : World news<a/>
  • [ ] nav2 : subnav : Environment<a/>
  • [ ] nav2 : subnav : Soccer<a/>
  • [ ] nav2 : subnav : US politics<a/>
  • [ ] nav2 : subnav : Business<a/>
  • [ ] nav2 : subnav : Tech<a/>
  • [ ] nav2 : subnav : Science<a/>
  • [ ] nav2 : subnav : Newsletters<a/>
  • [ ] nav2 : subnav : Fight to vote<a/>
  • [ ] nav2 : subnav-toggle<button/>
  • [ ] Front | /international<div/>
  • [ ] container-1 | palette-styles-new-do-not-delete<section/>
  • [ ] external | group-0 | card-@1<div/>
  • [ ] container-2 | ukraine-invasion<section/>
  • [ ] section heading<a/>
  • [ ] container-3 | headlines<section/>
  • [ ] treat | 1 | All world news stories<a/>
  • [ ] treat | 2 | Twitter<a/>
  • [ ] sublinks | 1<li/>
  • [ ] sublinks | 2<li/>
  • [ ] sublinks | 3<li/>
  • [ ] news | group-1 | card-@3<div/>
  • [ ] news | group-1 | card-@4<div/>
  • [ ] news | group-0 | card-@7<div/>
  • [ ] news | group-0 | card-@8<div/>
  • [ ] news | group-0 | card-@9<div/>
  • [ ] news | group-0 | card-@10<div/>
  • [ ] container-4 | spotlight<section/>
  • [ ] feature | group-1 | card-@4<div/>
  • [ ] feature | group-0 | card-@6<div/>
  • [ ] comment | group-0 | card-@7<div/>
  • [ ] feature | group-0 | card-@8<div/>
  • [ ] container-5 | climate-crisis<section/>
  • [ ] more<button/>
  • [ ] ad slot inline1<div/>
  • [ ] container-6 | opinion<section/>
  • [ ] comment | group-0 | card-@4<div/>
  • [ ] comment | group-0 | card-@5<div/>
  • [ ] comment | group-0 | card-@6<div/>
  • [ ] container-7 | sport<section/>
  • [ ] feature | group-0 | card-@5<div/>
  • [ ] ad slot inline2<div/>
  • [ ] container-8 | around-the-world<section/>
  • [ ] container-9 | documentaries<section/>
  • [ ] container-10 | contact-the-guardian<section/>
  • [ ] securedrop thrasher : container title<a/>
  • [ ] securedrop thrasher : inner area<a/>
  • [ ] container-11 | culture<section/>
  • [ ] feature | group-0 | card-@4<div/>
  • [ ] ad slot inline3<div/>
  • [ ] container-12 | lifestyle<section/>
  • [ ] container-13 | explore<section/>
  • [ ] treat | 1 | The long read<a/>
  • [ ] feature | group-0+ | card-@4<div/>
  • [ ] container-14 | take-part<section/>
  • [ ] container-15 | today-in-focus<section/>
  • [ ] audio-icon<div/>
  • [ ] apple<a/>
  • [ ] google<a/>
  • [ ] spotify<a/>
  • [ ] series<a/>
  • [ ] ad slot inline5<div/>
  • [ ] container-16 | videos<section/>
  • [ ] video-container-title Videos<a/>
  • [ ] video-container-prev<a/>
  • [ ] video-container-next<a/>
  • [ ] container-17 | in-pictures<section/>
  • [ ] treat | 1 | Picture essays<a/>
  • [ ] treat | 2 | From the agencies<a/>
  • [ ] treat | 3 | Photo highlights of the day<a/>
  • [ ] ad slot inline6<div/>
  • [ ] container-18 | most-viewed<section/>
  • [ ] most popular Test<div/>
  • [ ] tab 1 Most viewed<a/>
  • [ ] tab 2 Across the guardian<a/>
  • [ ] Most viewed<div/>
  • [ ] Across the guardian<div/>
  • [ ] keywords<div/>
  • [ ] all<a/>
  • [ ] keyword: world/europe-news<a/>
  • [ ] keyword: world/russia<a/>
  • [ ] keyword: world/ukraine<a/>
  • [ ] keyword: world/asia-pacific<a/>
  • [ ] keyword: world/vladimir-putin<a/>
  • [ ] footer : contribute-cta<a/>
  • [ ] footer : subscribe-cta<a/>
  • [ ] back to top<a/>
  • [ ] release message : overlay<div/>
  • [ ] release message<div/>
  • [ ] hide release message<button/>

Tag mismatch (42 / 263)

  • [X] nav2 : search : submit : <a /> ✗ should be → <button/>
  • [X] live | group-0 | card-@1 : <a /> ✗ should be → <div/>
  • [X] feature | group-0 | card-@2 : <a /> ✗ should be → <div/>
  • [X] news | group-0 | card-@3 : <a /> ✗ should be → <div/>
  • [X] news | group-0 | card-@4 : <a /> ✗ should be → <div/>
  • [X] news | group-2+ | card-@1 : <a /> ✗ should be → <div/>
  • [X] news | group-2 | card-@2 : <a /> ✗ should be → <div/>
  • [X] news | group-0 | card-@5 : <a /> ✗ should be → <div/>
  • [X] news | group-0 | card-@6 : <a /> ✗ should be → <div/>
  • [X] feature | group-2+ | card-@1 : <a /> ✗ should be → <div/>
  • [X] feature | group-2 | card-@2 : <a /> ✗ should be → <div/>
  • [X] feature | group-1 | card-@3 : <a /> ✗ should be → <div/>
  • [X] media | group-0 | card-@5 : <a /> ✗ should be → <div/>
  • [X] news | group-0 | card-@1 : <a /> ✗ should be → <div/>
  • [X] news | group-0 | card-@2 : <a /> ✗ should be → <div/>
  • [X] comment | group-1 | card-@1 : <a /> ✗ should be → <div/>
  • [X] comment | group-1 | card-@2 : <a /> ✗ should be → <div/>
  • [X] comment | group-1 | card-@3 : <a /> ✗ should be → <div/>
  • [X] live | group-2 | card-@2 : <a /> ✗ should be → <div/>
  • [X] news | group-1+ | card-@1 : <a /> ✗ should be → <div/>
  • [X] review | group-1 | card-@2 : <a /> ✗ should be → <div/>
  • [X] review | group-1 | card-@3 : <a /> ✗ should be → <div/>
  • [X] feature | group-1 | card-@1 : <a /> ✗ should be → <div/>
  • [X] feature | group-1 | card-@2 : <a /> ✗ should be → <div/>
  • [X] analysis | group-1+ | card-@1 : <a /> ✗ should be → <div/>
  • [X] news | group-1 | card-@2 : <a /> ✗ should be → <div/>
  • [X] media | group-0 | card-@1 : <a /> ✗ should be → <div/>
  • [X] media | group-0 | card-@2 : <a /> ✗ should be → <div/>
  • [X] feature | group-0 | card-@3 : <a /> ✗ should be → <div/>
  • [X] media | group-0 | card-@4 : <a /> ✗ should be → <div/>
  • [X] media | group-0 | card-@6 : <a /> ✗ should be → <div/>
  • [X] 1 | text : <li /> ✗ should be → <div/>
  • [X] 2 | text : <li /> ✗ should be → <div/>
  • [X] 3 | text : <li /> ✗ should be → <div/>
  • [X] 4 | text : <li /> ✗ should be → <div/>
  • [X] 5 | text : <li /> ✗ should be → <div/>
  • [X] 6 | text : <li /> ✗ should be → <div/>
  • [X] 7 | text : <li /> ✗ should be → <div/>
  • [X] 8 | text : <li /> ✗ should be → <div/>
  • [X] 9 | text : <li /> ✗ should be → <div/>
  • [X] 10 | text : <li /> ✗ should be → <div/>
  • [X] footer : <div /> ✗ should be → <footer/>

Identical match (106 / 263)

  • [X] ad slot top-above-nav<div/>
  • [X] nav2 : logo<a/>
  • [X] nav2 : job-cta<a/>
  • [X] nav2 : topbar : signin<a/>
  • [X] nav2 : search<a/>
  • [X] nav2 : topbar : edition-picker: US<a/>
  • [X] nav2 : topbar : edition-picker: UK<a/>
  • [X] nav2 : topbar : edition-picker: AU<a/>
  • [X] nav2 : topbar : edition-picker: INT<a/>
  • [X] nav2 : primary : News<a/>
  • [X] nav2 : primary : Opinion<a/>
  • [X] nav2 : primary : Sport<a/>
  • [X] nav2 : primary : Culture<a/>
  • [X] nav2 : primary : Lifestyle<a/>
  • [X] nav2 : secondary : US news<a/>
  • [X] nav2 : secondary : World news<a/>
  • [X] nav2 : secondary : Environment<a/>
  • [X] nav2 : secondary : Soccer<a/>
  • [X] nav2 : secondary : US politics<a/>
  • [X] nav2 : secondary : Business<a/>
  • [X] nav2 : secondary : Tech<a/>
  • [X] nav2 : secondary : Science<a/>
  • [X] nav2 : secondary : Newsletters<a/>
  • [X] nav2 : secondary : Fight to vote<a/>
  • [X] nav2 : secondary : The Guardian view<a/>
  • [X] nav2 : secondary : Columnists<a/>
  • [X] nav2 : secondary : Letters<a/>
  • [X] nav2 : secondary : Opinion videos<a/>
  • [X] nav2 : secondary : Cartoons<a/>
  • [X] nav2 : secondary : NFL<a/>
  • [X] nav2 : secondary : Tennis<a/>
  • [X] nav2 : secondary : MLB<a/>
  • [X] nav2 : secondary : MLS<a/>
  • [X] nav2 : secondary : NBA<a/>
  • [X] nav2 : secondary : NHL<a/>
  • [X] nav2 : secondary : F1<a/>
  • [X] nav2 : secondary : Film<a/>
  • [X] nav2 : secondary : Books<a/>
  • [X] nav2 : secondary : Music<a/>
  • [X] nav2 : secondary : Art &amp; design<a/>
  • [X] nav2 : secondary : TV &amp; radio<a/>
  • [X] nav2 : secondary : Stage<a/>
  • [X] nav2 : secondary : Classical<a/>
  • [X] nav2 : secondary : Games<a/>
  • [X] nav2 : secondary : Fashion<a/>
  • [X] nav2 : secondary : Food<a/>
  • [X] nav2 : secondary : Recipes<a/>
  • [X] nav2 : secondary : Love &amp; sex<a/>
  • [X] nav2 : secondary : Home &amp; garden<a/>
  • [X] nav2 : secondary : Health &amp; fitness<a/>
  • [X] nav2 : secondary : Family<a/>
  • [X] nav2 : secondary : Travel<a/>
  • [X] nav2 : secondary : Money<a/>
  • [X] nav2 : secondary : Make a contribution<a/>
  • [X] nav2 : secondary : Subscribe<a/>
  • [X] nav2 : secondary : Search jobs<a/>
  • [X] nav2 : secondary : Digital Archive<a/>
  • [X] nav2 : secondary : Guardian Puzzles app<a/>
  • [X] nav2 : secondary : Guardian content licensing site<a/>
  • [X] nav2 : secondary : The Guardian app<a/>
  • [X] nav2 : secondary : Video<a/>
  • [X] nav2 : secondary : Podcasts<a/>
  • [X] nav2 : secondary : Pictures<a/>
  • [X] nav2 : secondary : Inside the Guardian<a/>
  • [X] nav2 : secondary : Guardian Weekly<a/>
  • [X] nav2 : secondary : Crosswords<a/>
  • [X] nav2 : secondary : facebook<a/>
  • [X] nav2 : secondary : twitter<a/>
  • [X] nav2 : brand extension : Search jobs<a/>
  • [X] nav2 : brand extension : Digital Archive<a/>
  • [X] nav2 : brand extension : Guardian Puzzles app<a/>
  • [X] nav2 : brand extension : Guardian content licensing site<a/>
  • [X] article<a/>
  • [X] ad slot merchandising-high<div/>
  • [X] thrasher : little-warrior-2022 : container-title<a/>
  • [X] thrasher : little-warrior-2022 : main<a/>
  • [X] ad slot inline4<div/>
  • [X] ad slot mostpop<div/>
  • [X] ad slot merchandising<div/>
  • [X] footer : primary : News<a/>
  • [X] footer : primary : Opinion<a/>
  • [X] footer : primary : Sport<a/>
  • [X] footer : primary : Culture<a/>
  • [X] footer : primary : Lifestyle<a/>
  • [X] footer : us-morning-newsletter<a/>
  • [X] us : footer : about us<a/>
  • [X] us : footer : contact us<a/>
  • [X] complaints<a/>
  • [X] securedrop<a/>
  • [X] us : footer : work for us<a/>
  • [X] privacy<a/>
  • [X] cookie<a/>
  • [X] terms<a/>
  • [X] us : footer : tech feedback<a/>
  • [X] us : footer : all topics<a/>
  • [X] us : footer : all contributors<a/>
  • [X] digital newspaper archive<a/>
  • [X] us : footer : facebook<a/>
  • [X] us : footer : youtube<a/>
  • [X] us : footer : instagram<a/>
  • [X] us : footer : linkedin<a/>
  • [X] us: footer : twitter<a/>
  • [X] us : footer : newsletters<a/>
  • [X] us : footer : advertise with us<a/>
  • [X] us : footer : guardian labs<a/>
  • [X] us : footer : jobs<a/>

mxdvl avatar Apr 21 '22 14:04 mxdvl

See also #4698

mxdvl avatar Apr 22 '22 11:04 mxdvl

review on and after launch

VDuczekW avatar Dec 19 '22 15:12 VDuczekW

We need to implement this tracking before launch - we need to go through all the components, figure out if they have a datalink name and if not we need to add it as it should be the same as Frontend since these labels drive the GA data - this ticket makes it clear of all the stuff that's missing

rhiannareechaye avatar Jun 12 '23 13:06 rhiannareechaye

#4698

rhiannareechaye avatar Jun 12 '23 13:06 rhiannareechaye

Tracking progress of current ticket & #4698 here: https://docs.google.com/spreadsheets/d/1mrlXCd9Vd237Txw03v436eSoIuSrTvn6CzLpWsbmyfw/edit#gid=0

ioannakok avatar Jun 14 '23 17:06 ioannakok

Sub-tasks:

  • [x] Create ignore list: https://github.com/guardian/dotcom-rendering/pull/7988
  • [x] MPU Ad slots data-link-name: https://github.com/guardian/dotcom-rendering/pull/7979
  • [x] Snaps data-link-name: https://github.com/guardian/dotcom-rendering/pull/7964
  • [x] Video container
  • [ ] Podcast container
  • [x] Revisit Most Popular section. DOM is different between frontend & DCR after Deeply Read was added

ioannakok avatar Jun 15 '23 10:06 ioannakok

@ioannakok and @mxdvl hey both :) What do we need to do to close this issue?

rhiannareechaye avatar Jul 06 '23 13:07 rhiannareechaye

I understand now this is an automated ticket - seems like there a few items that are unticked. I don't think this is a blocker for us but @jamesgorrie is going to take a look too

rhiannareechaye avatar Jul 06 '23 14:07 rhiannareechaye

Done!

shesah avatar Nov 16 '23 16:11 shesah