Markus Vieth

Results 405 comments of Markus Vieth

As a general hint: there are two open pull requests (#2963 and #2964) that do similar things, but there were still some questions to be answered/design decisions to be made

@al-tu Are you still working on this? In the current state, it unfortunately does not compile ...

> i thought there is an opportunity to get rid of date_time incluclusion, but there's no easy way to do it I think date_time is mostly needed for `to_iso_string` and...

I don't fully understand some of the changes in `gpu`. Are they all a consequence of replacing the one `boost::array` with `std::array`?

@alexvorndran Based on what I saw so far, I would suggest that we deprecate and at some point remove the stick model. Not only that the model coefficients are treated...

> @mvieth I follow most of your observations, but would like to mention that in the cylinder model the radius is also determined based on only two sample points (and...

I recently found http://ann-benchmarks.com, which however mainly tests CPU implementations, but the readme on Github hints toward https://github.com/facebookresearch/faiss, which has a GPU implementation. I haven't looked into that at all...

If anyone is interested: this is still open. Here is a list of remaining header guards: [header_guards.txt](https://github.com/PointCloudLibrary/pcl/files/9138829/header_guards.txt) (I used grep with `ifndef.*h`, the list is probably complete but contains some...

@MallikharjunaTeja Great! Please open multiple smaller pull requests instead of one big pull request for the changes (maybe about 50-100 changed files per pull request)

@MallikharjunaTeja Are you still planning to open a pull request?