pcl icon indicating copy to clipboard operation
pcl copied to clipboard

Replace header guards of type `#ifndef` with a `#pragma once`

Open kunaltyagi opened this issue 5 years ago • 7 comments

Replace #ifndef header guard with a #pragma once

_Originally posted by @kunaltyagi in https://github.com/render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjQ0Nzg4MDI0OnYy/pull_request_review_threads/discussion

Maybe there's a clang-tidy flag to do this.

kunaltyagi avatar Mar 22 '20 14:03 kunaltyagi

Can I work on this?

0sidharth avatar Mar 23 '20 10:03 0sidharth

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

stale[bot] avatar May 19 '20 06:05 stale[bot]

If anyone is interested: this is still open. Here is a list of remaining header guards: header_guards.txt (I used grep with ifndef.*h, the list is probably complete but contains some false positives). I would recommend applying the changes in more than one pull request. The closed pull request above mentions some tools that may make the work easier.

mvieth avatar Jul 19 '22 08:07 mvieth

Hi @mvieth i want to work on this could you please assign me this

MallikharjunaTeja avatar Sep 10 '22 10:09 MallikharjunaTeja

@MallikharjunaTeja Great! Please open multiple smaller pull requests instead of one big pull request for the changes (maybe about 50-100 changed files per pull request)

mvieth avatar Sep 10 '22 12:09 mvieth

@MallikharjunaTeja Are you still planning to open a pull request?

mvieth avatar Oct 07 '22 09:10 mvieth

@mvieth I'll take up this issue

Zekrom-7780 avatar Nov 27 '23 11:11 Zekrom-7780