Markus Vieth

Results 359 comments of Markus Vieth
trafficstars

@SumitkumarSatpute Great! You could start with Idea 1. I would like to emphasize that not all functions/classes from Boost will be replaceable this way. The replacement should be C++14 compatible,...

> @mvieth https://github.com/gulrak/filesystem would be OK? Interesting, thanks for the link. We would not want to have that library as a dependency, because one reason to move away from Boost::filesystem...

`experimental/filesystem` is also not really what I had in mind. I don't have much experience with that, so I am not sure whether there is a guarantee when/which compilers offer...

@SumitkumarSatpute The logic to get the filename extension looks good, but what is `fs::path` and `fs::exists` in `hasExtension` and `fileExists`? @cybaol `path::stem` and `path::extension` seem to be available in 1.65.0...

Okay, let's start with the following: 1. Replace all occurrences of `boost::filesystem::basename` with `path::stem` (no checking for boost version needed) 2. For all occurrences of `boost::filesystem::extension(xyz)` where `xyz` is a...

@cybaol That is a good idea, but are `std::filesystem` and `boost::filesystem` that similar when it comes to classes, methods, and their behaviour? At least the ones PCL uses? If we...

I think a good next step would be to adapt https://github.com/PointCloudLibrary/pcl/blob/master/cmake/pcl_find_boost.cmake: If `CMAKE_CXX_STANDARD` is 17 or higher, do not list `filesystem` with the required boost modules, but with the optional...

@KStew8111 That is great! The first step would be adding two new functions: ```cpp PCL_EXPORTS void getMinMax3D (const pcl::PCLPointCloud2ConstPtr &cloud, const Indices &indices, int x_idx, int y_idx, int z_idx, Eigen::Vector4f...

Fixed by https://github.com/PointCloudLibrary/pcl/pull/5979

I agree that the description is not so great. Feel free to suggest a rewording, based on how ICP and JointICP use it.