Markus Vieth

Results 390 comments of Markus Vieth
trafficstars

@DIlkhush00 Great, feel free to open a pull request.

@Jean-Romain Thanks a lot for your comment! Regarding `# comments` in PCD files, I can only say that the PCD reader in PCL will treat lines in the header that...

@mascguy @michaelld Friendly ping. Would be great if you could review this. Thanks in advance!

@sharknow Does this always happen when you try to load a specific PCD file? If yes, please upload that file (zipped). In addition to the stack information you posted, is...

> It doesn't always happen, using the same PCD file, the next load will be normal. Still, please upload a PCD file (zipped) where the error has happened so that...

> I am using a Linux system. Which kind? Ubuntu, or Debian, or something else? Which version? > pcl: 1.10. PCL 1.10.0 or PCL 1.10.1? I assume you installed PCL...

Unfortunately, I do not have a promising idea what could be causing this problem. Inside PCL, we do not do anything extraordinary: First the file stream is opened: https://github.com/PointCloudLibrary/pcl/blob/af3ce2530b7ae8ed083a3515168626c587a5bbcd/io/src/pcd_io.cpp#L391-L392 then...

Thank you for your review. > Please add tests. I have added a test. If you want me to add more tests, please describe what they should do. > There...

@andyfaff I hope I did not miss anything while addressing your review. Could you take another look? Please tell me if there is anything left to do for me.

> Hi, just a quick question, setting `thread number = 1` will not spawn OpenMP worker threads? Like, exactly the same behaviour as before, with OpenMP optinal? I am not...