Manu Sridharan

Results 671 comments of Manu Sridharan

We're now at the end of 2023, and I think we should aim to drop support for running NullAway on JDK 8 in the near future. Specifically, I propose: 1....

Let's assume this was closed by #371 and open new issues for further support of streams

@liblit I am wondering if we can close this PR? It's most likely quite out of date, and potentially not even needed anymore. No big deal if you want to...

Sorry, I can't understand what error you are seeing. Can you point out the exact location where the error is reported and what the error message is? And also can...

> > Would it be possible for the check to not require these blank lines, and for the auto-fix not to insert them? > > I suppose we could introduce...

> Hey @msridhar, on your branch [msridhar/NullAway@7c8ac63#diff-d8162adf8ce392acc05a12713ac761cde51b50b4250a3d408cb04e66ee8ec85aR78](https://github.com/msridhar/NullAway/commit/7c8ac63ab855c9bd84a843a9e7feb92f044d62fd#diff-d8162adf8ce392acc05a12713ac761cde51b50b4250a3d408cb04e66ee8ec85aR78) I see some checks are [disabled](https://github.com/msridhar/NullAway/commit/7c8ac63ab855c9bd84a843a9e7feb92f044d62fd#diff-d8162adf8ce392acc05a12713ac761cde51b50b4250a3d408cb04e66ee8ec85aR77-R81). I can imagine most of these checks are quite opinionated and therefore may be less useful. >...

Hi there, if I understand correctly, you would like to treat `@RequestParam(required = false)` as equivalent to `@Nullable`? We do have support for [custom nullability annotations](https://github.com/uber/NullAway/wiki/Configuration#custom-nullability-annotations) but that just matches...

Thanks! Matching on parameters may not be difficult but it would have to be done with care to ensure no negative impact on NullAway performance when it is not required....