Manu Sridharan

Results 671 comments of Manu Sridharan

We have code like the following and GJF does not reformat the code to move the annotation immediately after the documentation block: ```java /** * Some docs */ public static...

> Yes I did and tried all the workarounds mentioned above but that didn't work unfortunately. I just confirmed that the workaround in https://github.com/google/google-java-format/issues/787#issuecomment-1212636955 works for me on IntelliJ Community...

@xenoterracide I finally got around to fixing up the docs in #843. Sorry for the huge delay, and thanks again for the contribution here.

Hi @xenoterracide we are unlikely to have any resources in the near future to devote to adding a mode where NullAway assumes vars are `@Nullable` by default. I think it...

Sorry for the trouble @xenoterracide. The flag you want is `ExcludedFieldAnnotations`, e.g.: ``` option("NullAway:ExcludedFieldAnnotations", "org.junit.jupiter.api.io.TempDir") ``` Docs are [here](https://github.com/uber/NullAway/wiki/Configuration#excluded-field-annotations).

@wbadam exciting to hear you are working on rolling out NullAway at Canva! Given the number of times this has come up, I would be open to trying to address...

I have renamed this issue to focus on the false positives stemming from cases like those in https://github.com/uber/NullAway/issues/98#issuecomment-354630644. > @msridhar certainly happy to look into it, a direction to the...

Thanks a lot @cpovirk! That's very interesting. The inlining approach is appealing in terms of trying to make the results of dataflow not depend on whether you store certain types...

Upon further thought, I think we shouldn't be too aggressive in dropping Java 8 support. There are scenarios in which libraries that still want to target Java 8 would want...