NullAway icon indicating copy to clipboard operation
NullAway copied to clipboard
verified publisher icon uber

Remove support for running on JDK / Java 8

Open msridhar opened this issue 3 years ago • 2 comments

Error Prone dropped support for Java 8 several months ago:

https://github.com/google/error-prone/releases/tag/v2.11.0

Dropping Java 8 support will allow us to clean up several ugly hacks in the NullAway code and build configuration. We'll aim to cut one final release supporting Java 8 before doing this.

msridhar avatar Aug 08 '22 17:08 msridhar

Upon further thought, I think we shouldn't be too aggressive in dropping Java 8 support. There are scenarios in which libraries that still want to target Java 8 would want to build on a JDK 8 JVM, and NullAway dropping that support would make things more inconvenient. I think we can survive with the hacks we have for now. Leaving this open as we want to do this eventually

msridhar avatar Oct 27 '22 01:10 msridhar

We're now at the end of 2023, and I think we should aim to drop support for running NullAway on JDK 8 in the near future. Specifically, I propose:

  1. In the next release, document that we plan for that release to be the last that supports running on JDK 8.
  2. Assuming we do not learn of any major issues, drop support in the following release, potentially doing a larger version number bump to indicate a significant change.

@lazaroclapp @yuxincs thoughts?

msridhar avatar Dec 20 '23 17:12 msridhar