Manu Sridharan

Results 671 comments of Manu Sridharan

I haven't seen test code like this before. It seems like it might be a lot of work to support this framework and its semantics. You might be best off...

@cushon I think as a corner case one might not be 100% safe with `--release` if code uses JDK-internal APIs? See, e.g., the issues we ran into with Error Prone...

@cushon I'm not sure if I should open a separate issue for this, but one thing that impacts NullAway is that Error Prone does not yet have a `BugChecker.SwitchExpressionTreeMatcher` interface...

@aik099 I just tried that; `err` is `undefined`.

Digging a bit deeper, the `onclick` handler script seems to be executed via this code in jsdom: https://github.com/tmpvar/jsdom/blob/0.8.11/lib/jsdom/level2/events.js?source=cc#L196 The catch block at line 198 is reached, but `e` is undefined,...

@sdeleuze FYI we just released NullAway 0.10.25 with fixes for some (but not yet all) of the issues you reported.

Thanks for looking into it! Not a huge deal for us. Feel free to close if this is a duplicate

Just wanted to say we still face #149 regularly and would love to see this one landed!

Unfortunately I haven't had time to look at this, and may not for a while. If I get time to work on it I will comment here

Thanks for the report. This is related to #660 and generics support, which we are actively working on (/cc @NikitaAware). Our first milestone here would be an ability to opt...