Manu Sridharan

Results 671 comments of Manu Sridharan

My goal is to be able to ship a plugin check that is disabled by default (like the "Experimental" checks shipped with Error Prone). So I don't think `-XepDisableAllSuggestions` does...

I agree that updating Error Prone to disable warnings by default could be disruptive. If we add the feature to the `@BugPattern` annotation to disable a check unless explicitly enabled,...

I can try to put up a PR for this but it will probably take me some time...in case someone else wants to take it on 🙂

@sdelamo have you signed the CLA? We'll need that signature before we can merge this.

@sdelamo any update on the CLA?

An initial proposal here: * We replace the `AcknowledgeRestrictiveAnnotations` flag with something like `IgnoreRestrictiveAnnotations`, and make acknowledging restrictive annotations the default. This way, "unannotated" and `@NullUnmarked` mean the same thing...

> * `IgnoreRestrictiveAnnotations` would be a bit of a silly name, the original name was based on "accept annotations here iff they are more restrictive than our optimistic defaults", if...

I noticed a couple of the tests involve enhanced for loops. When bringing in the tests to the conformance suite it may be good to separate handling of enhanced for...

We've changed our approach here rather significantly. We're now using a `javac` plugin to extract the nullness info out of `jspecify/jdk`. #1333 is our latest work on this approach, and...

Not 100% sure, but I think I filed [a Checker Framework issue](https://github.com/typetools/checker-framework/issues/7032) for something similar to this (but it doesn't involve generics): ```java import org.checkerframework.checker.nullness.qual.Nullable; public class Test { sealed...