Manu Sridharan

Results 680 comments of Manu Sridharan

From the NullAway perspective, we have supported a subset of the functionality of JetBrain's `@Contract` annotation for quite some time (looks like [since March 2018](https://github.com/uber/NullAway/commit/e20088d3aacb5d421039a62066deeadbddfeaa49)). This was motivated by internal...

Hey, not sure I'm fully following the discussion, but NullAway handles `@NullUnmarked` as follows (this ignores generics, arrays, etc.): 1. `@NullUnmarked` method parameters are treated as `@Nullable` and the return...

> can you explain what you mean by: > > > 1. `@NullUnmarked` method parameters are treated as `@Nullable` > > given that the 2 examples above are handled differently...

@bannmann NullAway should support `@NullMarked` and `@NullUmarked` now! Can you open a separate bug if you're seeing that it's not supported? The only place where support likely won't work yet...

Regarding your suggested configurations options @bannmann I like them! We are going to have a messy and probably somewhat lengthy transition over to JSpecify checking, with an unfortunate amount of...

@pemistahl @beatbrot continuing from #1042, see the discussion above. We now have a [JSpecify mode flag](https://github.com/uber/NullAway/wiki/JSpecify-Support), and we also support `@NullMarked` and `@NullUnmarked`. @pemistahl if you are seeing a case...

> Exactly, that's what I have in mind, too. I want to be able to decide whether to check on package level or on class level. We have an application...

@sdeleuze thanks for the feedback. I can prioritize adding a flag like `OnlyNullMarkedCode` that, if provided, makes `AnnotatedPackages` optional. And, once JSpecify is more ubiquitous, maybe we can even make...

This will be fixed in the next release; the new flag name is `OnlyNullMarked`. See the [docs](https://github.com/uber/NullAway/wiki/Configuration).

This fix is released now in NullAway 0.12.3