Manu Sridharan

Results 671 comments of Manu Sridharan

How are you running tests? In Eclipse? IntelliJ? On Tue, Aug 28, 2018 at 11:30 AM Jacoppy wrote: > Well, I have tried both gradle and JUnit tests. > Even...

Ok, I don't use Eclipse anymore. We'll need help from @juliandolby here On Tue, Aug 28, 2018 at 11:37 AM Jacoppy wrote: > Being more precise, Eclipse photon on Ubuntu...

No problem, glad to help! On Tue, Aug 28, 2018 at 11:44 AM Jacoppy wrote: > Okay, anyway the good thing is that all gradle tests work correctly. I'll >...

In order to actually help here, we need step-by-step instructions on how to reproduce.

You need to run `./gradlew goJF` locally to format the code correctly with Google Java Format. You can also run `./gradlew installGitHooks` to have GJF run locally on every commit.

Can we add a regression test for this new code? Like package some classes into a `.war` file during testing and then try to load it?

@coder-chenzhi what is your usage scenario? We used to have more J2EE support in WALA many years back but it was unmaintained and got removed. Beyond handling WAR files, usually...

Thanks for the contribution @izgzhen! I think we need a bit more, though. Arrow functions differ semantically from function expressions in important ways. See this article: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions#Description At the least,...

Cool! This is kind of a long comment explaining how this might be done. I understand it could be kind of intimidating, but I think it's doable with some effort...