Sean Gilligan

Results 630 comments of Sean Gilligan

> I'd like to add that the entire script verification is terribly outdated and probably hasn't been correct at any point in time. > > (I've tried to remove it...

Linux aarch64 is available for 21.01. (See https://repo1.maven.org/maven2/org/openjfx/javafx-graphics/21.0.1/)

If we merge PR #3882 this is no longer an issue (unless or until an OpenJFX 25 patch release comes out without `aarch64-linux` support.

Gluon says they will be releasing `aarch64-linux` binaries for all upcoming releases: > Yes, we plan to build [aarch64-linux binaries] for all upcoming releases, but not supported by our commercial...

We've merged a handful of PRs that should help with this: * PR #3590 * PR #3591 * PR #3592 * PR #3593 * PR #3594 Based on these PRs...

I'm running WalletTemplate on MAINNET after merging the above PRs and they are definitely an improvement. However, I'm still seeing at least two messages that seem unnecessarily verbose (1): ```...

(3) These two messages could probably be combined. (e.g. a single message that says that the peer died and why "Timed out") ``` 22:30:01.095 50 PeerSocketHandler.timeoutOccurred: [178.176.79.216]:18333: Timed out 22:30:01.095...

It might also be helpful to print summary information (how many peers we successfully attempted to connect to and how many were unsuccessful in an n-minute period. This summary information...

> Investigated more into the usages of `Script.setCreationTimeSeconds()`, and it's only used for watching addresses like I suspected. If that's the only place it is used, maybe we should make...

> Furthermore, we should perhaps think about removing `@Deprecated public Script(byte[] program)` again? I'm not sure what you mean here. We've already removed it on `master`. Are you suggesting we...