Sean Gilligan

Results 630 comments of Sean Gilligan

I made two related, minor PRs: * PR #3851 * PR #3852 Both of these changes were the result of reviewing this PR and looking at the interface and documentation...

> @msgilligan I see the PR if flagged with "changes requested" but I don't see anything. I just now found the UI option to re-request my own review (I tried...

Hi Jeff, thanks for your patience! Here are my suggested changes: https://github.com/bitcoinj/bitcoinj/pull/3909 We also need to rebase onto `master`.

> I'll get to them tonight. Thank you! - Jeff Awesome! I thought that there was a way to associate the new PR with this one (like the suggest changes...

Although this ran successfully on GitHub actions when I first submitted it, as of today it is failing. Probably because of this issue: https://github.com/actions/setup-java/issues/692. See the comment that says it...

> Although this ran successfully on GitHub actions when I first submitted it, as of today it is failing. Probably because of this issue: [actions/setup-java#692](https://github.com/actions/setup-java/issues/692). See the comment that says...

> Just for clarification: does this mean that instead of removing `17` we could change it to `17.0.12`? Yes, we could. But then we'd be using something that from our...

Yeah, I'll make a PR for the `java-version` → `java` rename. Then we can rebase this PR and leave it open. If/when https://github.com/actions/setup-java/issues/742 is resolved, we can update this PR...

One name I've been considering for a wallet `interface` is `WalletService`. `WalletAppKit` and/or the protobuf `Wallet` could implement this interface.

I have updated the build to require JDK 17: See PR #160