Sean Gilligan

Results 630 comments of Sean Gilligan

PR #3647 and some related work has (at least partly) been in preparation for adding Testnet 4 support. This work is being done on the `master` branch and is slated...

> Once the update is final, I'm fine with it. BTW, Sparrow has now tested with it and will be using it in the next Sparrow release.

PR #3850 was merged to eliminate circular dependencies (for Maven) so we need to rethink this PR.

> Which version of the plugin did you use? 3.1.3 You can reproduce it with the `msgilligan/gradle-jlink-jep-493-sample` project. on macOS: ``` sdk use gradle 9.1.0 sdk use java 25-tem gradle...

To be clear, I don't this should be a high priority: Gradle 10 won't happen for a while and until it is released, the only thing a fix for this...

At the very least you could just document that macOS users need to install GNU sed. It was pretty easy to figure out, but a comment in the script or...

> > * The `PeerMonitorFx` fails to start up and gives an error that says > ``` > > JavaFX runtime components are missing, and are required to run this...

@ItoroD See PR #3832 for changes I made to move this to its own module and some other minor improvements. Let's see what @schildbach says about creating a new module...

I think we should downgrade to 21.0.1 to fix the ARM build until there is a better solution available. It's only sample code and anything real built with it as...

Making _DRAFT_ for now. The `Prefix.M` / `Prefix.m` addition is controversial and not needed for short-term, so we can shelve that for now. The deprecated constructor may have to be...