Sean Gilligan

Results 630 comments of Sean Gilligan

I don't think we do that much with mocking and as far as I know we have no issues with EasyMock. How hard would it be to convert existing tests...

@hasskell I created Issue #3840 to consider migrating the build to Maven, which would open the door to migrating all tests to JUnit 5. Would you feel comfortable trying to...

> Do we already have warnings in place in JavaDocs and comments? I'll make sure there are. ( add **and JavaDoc** to the first comment to make that more clear)

PR #3508 adds @Deprecations and warnings to the Java source.

> my blockchain download process stopped at block 849137 I'm using BitcoinJ 16.2 from the Maven repository How can I solve the problem? There will be a bitcoinj 0.16.3 release...

**Bitcoin Core** uses a 32-byte (256-bit) value using types uint256 and arith_uint256. So maybe we should just serialize the value as 32-bytes. `SPVBlockStore` is formatted according to the following comment:...

@schildbach Sounds like a plan. Should we target this for 0.17 as currently labelled?

I just tagged this as a candidate for the `0.18` release. (I thought I had already done that.) Andreas has been away and has a large backlog of PRs (mostly...

> @msgilligan the PR has the "changes requested" status. Is there something I need to do? I can't seem to clear the status, perhaps only you can. Looks like I...

> I'm new to the project, so I'm good with any needed changes. Great, thanks for bearing with me. > BTW, please let me know if you receive this... I...