Sean Gilligan

Results 630 comments of Sean Gilligan

> I agree about the negliable performance difference when signing. What do you think about the problem that unparseable scripts cannot be signed any more? I guess there are two...

More information needs to be provided. The actual error message was not provided nor any information about how bitcoinj is being used with Android/Dagger/Hilt. Please provide more information. If we...

> Interesting. What ability do we gain with this? I'm not exactly sure. Possible interoperability with Java Cryptography APIs that use AES? There may also be some Bouncy Castle methods...

> This is now all 1 commit. Is that intentional? I find it hard to understand that way. This set of changes was one commit all along. I will be...

This commit is superseded by: * PR #3762 * PR #3763 * PR #3764 Once those are merged we should probably do a final `diff` to see if there is...

I'm thinking we should make `BriefLogFormatter` a no-op and deprecate it in 0.18 and remove it in 0.19. We can move the existing implementation to the examples subproject for those...

> CI seems unhappy. That's because I made the wallettemplate module build conditional on JDK 23, but the GHA `build.gradle` file unconditionally calls `jlink` and `installDist` in that module. I...

Splitting the `jlink` and `installDist` Gradle tasks into a separate, conditional GHA step fixed the issue.

In my experience (and Sparrow somewhat confirms this) JavaFX apps need to be shipped with a recent (normally the latest LTS release) of JavaFX for best results, so we should...

> 17→25 is a huge jump, skipping 21 (also an LTS). JavaFX is (effectively) making the same jump, see the [Roadmap](https://gluonhq.com/products/javafx/). JavaFX 21 (LTS) requires JDK 17 and JavaFX 25...