Okan Sahin
Okan Sahin
Re-adding the labels as this had already been tested and the "untested" exception PR is on production since a week, so we can consider that one-line-code-change tested.
Should be close to impossible for this to cause test failures, I'll merge this and it should work on stage.
@skholkhojaev - how would those two conditions end up breaking the site? > Preflight running way too early and not waiting for everything to be loaded the assets.js were trying...
fyi @skholkhojaev you are having a conflict and will need to rebase
Make sure all the checks are green, the unit tests currently are still failing!
Could we also adapt the slack notification that we have before RCPs? Would be great if we announce when both stage and prod are disabled ``` Reminder RCP starts in...
re nala errors, i think rebasing to stage should fix those
Looks good from a code perspective, am neutral from a design perspective, hence hesitant to approve. To be fair, it's a tool designed by engineers and IMO engineers should not...
PS: U'd also need to have a matching PR to main https://github.com/adobecom/milo/pull/4416 ... however that one we can't really merge during the RCP 😁
Few nits and simplifications / leaner code / readability! BTW All the suggestions are purely demo code and untested! Should ideally function as is mostly though