Okan Sahin

Results 53 comments of Okan Sahin

Spotted another issue, however, we are loading `icon.js` twice & there seem to be some nala tests failing https://main--dc--adobecom.hlx.live/acrobat/how-to/pdf-to-word-doc-converter?milolibs=rparrish-fed-icons--milo--adobecom ![Screenshot 2024-11-04 at 11 31 33](https://github.com/user-attachments/assets/ac94360c-9881-459e-aee2-77845493ee6e)

> @mokimo Could you please provide more details? I couldn't reproduce the missing icon This seems to be happening sporadically and not consistently @saugatmalla It might be a timing issue,...

@meganthecoder not blocking the PR but the preflight tool doesn't seem to work OOTB, on the first click there's a JS error, on the second one an error from within...

Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/4407 why/what is blocking this from proceeding?

Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/4407 why/what is blocking this from proceeding?

Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/4407 why/what is blocking this from proceeding?

Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/4407 why/what is blocking this from proceeding?

@Blainegunn it does seem like some MAS related nala tests are failing 😕

This is ready for stage as the changes should already be on production.

@Blainegunn / @TsayAdobe it's good enough if this gets merged after the RCP, right?