Okan Sahin

Results 53 comments of Okan Sahin

I went a step further to ensure we build the placeholders on a per-section-basis AND only if we have them. If section 5 has placeholders, there is no reason we...

CC test links - Before: https://main--cc--adobecom.hlx.live/de/products/photoshop?martech=off - After: https://main--cc--adobecom.hlx.live/de/products/photoshop?milolibs=placeholder-lcp-improvements--milo--mokimo&martech=off

@afmicka can you recheck? should be fixed now @SilviuLCF this is ready for testing now

Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/4407 why/what is blocking this from proceeding?

Let's turn this into a real PR and not a draft - we'll definitely need a fix for this.

Could you create a test page with a marquee with say 3 icons after, and the sheet before? I'd love to run a few performance tests on that

We also don't only load the icons relevant for a section (LCP), but ALL ICONS on the page in one go. ![Screenshot 2024-10-07 at 10 32 52](https://github.com/user-attachments/assets/d2de1653-6b47-4a52-b61c-3d0d4918a300) > Marquee below...

There's also some spacing differences in the marquee "illustrator aktivieren" icon & it leads a small bug in the georouting modal ![image](https://github.com/user-attachments/assets/bb004cc6-c31f-42dd-8789-33d6e2b54372)

There's a unit test failing: > test/features/icons/icons.test.js: ❌ Icon Suppprt > Sets icon index class TypeError: setIconsIndexClass is not a function at n. (test/features/icons/icons.test.js:50:5) and on CC the icon is...