MWPW-183267: Improve preflight dialog layout
Resolves: MWPW-183267
Test URLs:
- Before: https://main--milo--adobecom.aem.page/?martech=off
- After: https://MWPW-183267-preflight-css--milo--hparra.aem.page/?martech=off
Unrelated nala test failed. retry too. Commerce-related.
Error: 1) [mas-chromium] › features/commerce/commerce.test.js:306:7 › Commerce feature test suite › @Commerce-DE, @commerce @smoke @regression › Validate Buy now CTA
TimeoutError: locator.waitFor: Timeout 10000ms exceeded.
Call log:
- waiting for locator('//a[contains(@daa-ll, "Buy now")]') to be visible
326 |
327 | await test.step('Validate Buy now CTA', async () => {
> 328 | await COMM.buyNowCta.waitFor({ state: 'visible', timeout: 10000 });
| ^
329 | await expect(COMM.buyNowCta).toHaveAttribute('data-promotion-code', data.promo);
330 | await expect(COMM.buyNowCta).toHaveAttribute('href', new RegExp(`${data.promo}`));
331 | await expect(COMM.buyNowCta).toHaveAttribute('href', new RegExp(`${data.CO}`));
at /home/runner/work/milo/milo/nala/features/commerce/commerce.test.js:328:28
at /home/runner/work/milo/milo/nala/features/commerce/commerce.test.js:327:16
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.
re nala errors, i think rebasing to stage should fix those
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.
@robert-bogos rebased but still an unrelated MAS issues
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.
Looks good from a code perspective, am neutral from a design perspective, hence hesitant to approve. To be fair, it's a tool designed by engineers and IMO engineers should not have design-discussions, but that's too late. 😁
@overmyheadandbody or @narcis-radu or generally @adobecom/milo-core wdyt?