milo icon indicating copy to clipboard operation
milo copied to clipboard

MWPW-183267: Improve preflight dialog layout

Open hparra opened this issue 2 months ago • 5 comments

Resolves: MWPW-183267

Test URLs:

  • Before: https://main--milo--adobecom.aem.page/?martech=off
  • After: https://MWPW-183267-preflight-css--milo--hparra.aem.page/?martech=off

hparra avatar Nov 04 '25 23:11 hparra

Unrelated nala test failed. retry too. Commerce-related.

Error:   1) [mas-chromium] › features/commerce/commerce.test.js:306:7 › Commerce feature test suite › @Commerce-DE, @commerce @smoke @regression › Validate Buy now CTA 
    TimeoutError: locator.waitFor: Timeout 10000ms exceeded.
    Call log:
      - waiting for locator('//a[contains(@daa-ll, "Buy now")]') to be visible


      326 |
      327 |     await test.step('Validate Buy now CTA', async () => {
    > 328 |       await COMM.buyNowCta.waitFor({ state: 'visible', timeout: 10000 });
          |                            ^
      329 |       await expect(COMM.buyNowCta).toHaveAttribute('data-promotion-code', data.promo);
      330 |       await expect(COMM.buyNowCta).toHaveAttribute('href', new RegExp(`${data.promo}`));
      331 |       await expect(COMM.buyNowCta).toHaveAttribute('href', new RegExp(`${data.CO}`));

        at /home/runner/work/milo/milo/nala/features/commerce/commerce.test.js:328:28
        at /home/runner/work/milo/milo/nala/features/commerce/commerce.test.js:327:16

hparra avatar Nov 04 '25 23:11 hparra

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar Nov 05 '25 01:11 github-actions[bot]

re nala errors, i think rebasing to stage should fix those

mokimo avatar Nov 12 '25 16:11 mokimo

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Nov 22 '25 01:11 github-actions[bot]

@robert-bogos rebased but still an unrelated MAS issues

hparra avatar Nov 22 '25 02:11 hparra

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Dec 01 '25 02:12 github-actions[bot]

Looks good from a code perspective, am neutral from a design perspective, hence hesitant to approve. To be fair, it's a tool designed by engineers and IMO engineers should not have design-discussions, but that's too late. 😁

@overmyheadandbody or @narcis-radu or generally @adobecom/milo-core wdyt?

mokimo avatar Dec 02 '25 09:12 mokimo