milo icon indicating copy to clipboard operation
milo copied to clipboard

[MWPW-182344] Merge-to-Stage restriction on Fridays and Thursdays before RCP

Open skholkhojaev opened this issue 2 months ago • 4 comments

added a workingHours() and there should be no merge to stage batches happening in friday+weekends to keep the batch clean for CSOs/quick VP-approved PRs

Same goes for the RCP

Resolves: MWPW-182344

Test URLs:

  • Before: https://main--milo--adobecom.aem.page/?martech=off
  • After: https://no-stage-RCP--milo--skholkhojaev.aem.page/?martech=off

skholkhojaev avatar Oct 22 '25 09:10 skholkhojaev

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar Oct 30 '25 01:10 github-actions[bot]

Could we also adapt the slack notification that we have before RCPs? Would be great if we announce when both stage and prod are disabled

Reminder RCP starts in 13 days: from Sun, 16 Nov 2025 08:00:00 GMT to Sat, 29 Nov 2025 08:00:00 GMT. Merges to stage will be disabled beginning Fri, 14 Nov 2025 08:00:00 GMT.

mokimo avatar Nov 03 '25 14:11 mokimo

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Nov 11 '25 01:11 github-actions[bot]

I've added the slack logic part in the helpers.js alongside other RCP slack messages, is that fine or would you rather i put it in the same file?

skholkhojaev avatar Nov 12 '25 10:11 skholkhojaev

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Nov 28 '25 01:11 github-actions[bot]