Okan Sahin
Okan Sahin
@sivasadobe it seems that the PSI check is failing - the automation process won't pick this PR up if the checks are not passing. see https://github.com/adobecom/milo/pull/2230#issuecomment-2087806049
Sorry for zero-impact spam, using ur branch to test 😬
Why not use metadata to read the input & output url? I don't know if the block is already used anywhere, but that way you could roll out the new...
@sanrai you could close this PR and open a new one from your own fork
Seems like PSI is having a bad day. Can be ignored.
@overmyheadandbody did you encounter this on the `marquee-cls` branch or prod? That's the CLS that should have gotten fixed with this. I can reproduce it on main, but can't reproduce...
@SilviuLCF can you see if you can reproduce what @overmyheadandbody saw? 🤔 I don't think it's a blocker, we can also merge and see in RUM if it still appears.
Moving some of the tests to the description: Onviewport play - Before: https://main--milo--mokimo.hlx.live/drafts/siva/products/videoplay-onviewport?martech=off - After: https://marquee-cls--milo--mokimo.hlx.live/drafts/siva/products/videoplay-onviewport?martech=off Only desktop (mobile should not load the video for perf reasons) - Before: https://main--milo--mokimo.hlx.live/drafts/seanchoi/marquee-video?martech=off...
Wouldn't this mean that we now load extra bytes when promos are not used, making performance slightly worse in those cases?
_Still resolving a bug in CC that fetches placeholders a few too many times... Still want to open this already (mainly to not lose the precious description I already done)_...