Michael Carroll

Results 315 comments of Michael Carroll

@davidhodo This the corrected link: https://github.com/ros2/ros2_documentation/blob/master/source/Roadmap.rst#design--concept

Flake8 issue was addressed here: https://github.com/ros2/ros2cli/pull/805

@dirk-thomas Do you recall the reason why `rosidl` wraps constants in an enum?

I think that the issue stems from the fact that the underlying type of the `enum`, which I believe is at least a signed type (I think width is implementation...

@serge-nikulin Typing the enums should not make them an enum class, they will retain the properties of a normal (pre-C++11) enum, with the underlying type explicitly stated: http://en.cppreference.com/w/cpp/language/enum The `enum...

I think that `const` probably makes the most sense, as long as we are okay with moving away from the `enum`, which is the "legacy solution" at this point.

@serge-nikulin Do you know how this affects the MISRA C compliance? It appears that I am unable to use the same fix for C as I did C++, because `static`...

The issue is that if we change the definition of `lifecycle_msgs__msg__State__PRIMARY_STATE_UNKNOWN` from an `enum` (what it originally was) to a `static const TYPE` (what we had to do in C++),...

@stonier What's the status of this? Did #52 provide any steps towards resolving this?

Everything up to `rclcpp`/`rclpy` have been approved and merged. I'm going to leave this to you to close when demos/documentation are updated. Thanks for all the hard work and iteration!