Michael Carroll

Results 315 comments of Michael Carroll

Fixing branch names in #387 and #388

It seems to me that there shouldn't be a heartbeat during the bring up because of the reason that you stated. It was introducing flakiness in the test_bond tests. For...

I agree that the naming could be a little better, I don't have the bandwidth to tackle at the moment. Any PRs in this direction would be appreciated.

Howdy @traversaro , will take a look at this once I can get #87 landed to get a majority of the "cleanups" in.

@Tobias-Fischer friendly ping

@VasuAgrawal do you have any further information on this? What version of ROS are you using? What version of bond are you using?

@corot Do you have a repository I could use to verify this behavior?

Thanks for the pings, new release here: https://github.com/ros/rosdistro/pull/35596

@ianjfrosst Thanks for the heads up. I think that the correct thing to do here would be to move those GUI-dependent scripts into their own package to keep them out...

I'm okay with modifying the layout of the repository for the same reasons that @gavanderhoorn has stated above.