rcl icon indicating copy to clipboard operation
rcl copied to clipboard

Published 20 hours ago • verified publisher icon ros2

Cleanup the dependencies in rcl_yaml_param_parser.

Open clalancette opened this issue 3 years ago • 1 comments

The main goal of this commit is to make sure that the dependencies listed in the package.xml and the CMakeLists.txt are correct. To get there, we first go through all of the files in this package and make sure that the includes are correct. With that done, it is a simple matter of seeing what is needed and not in the depends and the tests.

While we are in here, we also switch from ament_target_dependencies to target_link_libraries wherever possible.

Signed-off-by: Chris Lalancette [email protected]

clalancette avatar Oct 20 '22 19:10 clalancette

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette avatar Oct 20 '22 19:10 clalancette

New CI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette avatar Feb 13 '23 14:02 clalancette

Flake8 issue was addressed here: https://github.com/ros2/ros2cli/pull/805

mjcarroll avatar Feb 13 '23 17:02 mjcarroll

CI is green (modulo the one unrelated problem), and approved. Thanks for reviewing, merging.

clalancette avatar Feb 13 '23 19:02 clalancette