David Wong
David Wong
ah yeah, here it is: ```rust pub struct SingleLookup { /// Linear combination of local-positions pub value: Vec, } ``` might be a good idea to do ```rust /// scaling...
@rot256 if you actually look at this code (don't worry about it otherwise), it'd be nice to have a review so that we can at least get that code in...
@rot256 is proposing something even simpler: https://gist.github.com/rot256/d0b86b406e45b8dda2baccc2154ebf4d
I had to split the first commit into two so that it's easier to review: * https://github.com/o1-labs/proof-systems/commit/e301d918c1386d6b55d40b5c74fa5c07c349c5d8 * https://github.com/o1-labs/proof-systems/commit/3c59545e3f5fe7271ea808cfebf4f82095daf150 (always a good idea to split your PR into readable commits...
perhaps there is a way to enforce this using types or something
I was under the impression that we never use the generator specified in arkworks in our code, maybe I missed a place EDIT: Ah I guess the signer might, cc...
another thing, at a minimum we should move to their new way of doing this: https://github.com/arkworks-rs/curves/blob/master/pallas/src/fields/fq.rs
I don’t think so but I might be wrong. Let’s just make this issue about defining things more clearly like in arkworks for now :o I just got enthusiastic about...
cool thanks : ) don't hesitate to ping me here or on twitter if you have questions.
I've toyed with it here: https://github.com/o1-labs/proof-systems/pull/455