JointLookup should not have SingleLookup inside

[mimoo]

I think this struct is not correct, as in: there should not be a single lookup inside a jointlookup

pub struct JointLookup<F> {
    pub table_id: usize,
    pub entry: Vec<SingleLookup<F>>,
}

I think this can be written as:

pub struct JointLookup<F> {
    pub table_id: usize,
    /// linear combination of local positions
    pub entry: Vec<(F, LocalPosition)>,
}

[mrmr1993]

This would actually need to be entry: Vec<Vec<(F, LocalPosition)>>; it's probably clearer to keep the SingleLookup type to avoid the type complexity.

[mimoo]

ah yeah, here it is:

pub struct SingleLookup<F> {
    /// Linear combination of local-positions
    pub value: Vec<(F, LocalPosition)>,
}

might be a good idea to do

/// scaling of a witness by a fixed field element.
pub type ScaledWitness = (F, LocalPosition);

/// A single lookup of a linear combination of registers / witness columns
pub struct SingleLookup<F>(Vec<ScaledWitness>);

[github-actions[bot]]

Stale issue message

[github-actions[bot]]

Stale issue message

[github-actions[bot]]

Stale issue message