David Wong
David Wong
there's also `SquareRootField` used in some places
as a helper: ```rust /// The interface for a field that supports an efficient square-root operation. SquareRootField: Field PrimeField: Field + FftField FftField: Field ```
I don't think the validation matters for now. We should have separate functions for that if we ever deserialize from untrusted source. But we should have these skipped fields be...
In addition, we should remove serialization logic from the stubs in mina
Adding more color to this issue: The relevant code is here: https://github.com/o1-labs/proof-systems/blob/master/kimchi/src/prover.rs#L109 ```rust //~ 1. Ensure we have room in the witness for the zero-knowledge rows. //~ We currently expect...
there's also ZK_ROWS in lookup as well. I think it might be good to rename `ZK_ROWS` to `EVALS` or some constant that says how many evaluations we have in the...
An explanation from @kevaundray that I found really useful: So if you imagine that you need to compute the following circuit: x = 1/y t + x = 0 I...
to add more colors, this would be for the circuit-writer
note: that might be a bit annoying to refactor on the ocaml side, but good to use this issue as brainstorming for this longer term refactor
we could use this issue to talk about refactoring the indexes in general. There is a number of improvements we've discussed in different places, but summarized: - [ ] ConstraintSystem...