David Wong
David Wong
https://github.com/MinaProtocol/mina/blob/5d02731d3e441ffd4a8acbee4d69d8e55b6f01b5/src/lib/pickles/commitment_lengths.ml#L6 < here are the size of the commitments we expect
I think it's a good idea to use a strong type instead of a vec/array, but if we do use a strong type I think we should go all the...
@imeckler proposes a macro that just gives you an iter over the fields: ``` fn iter_fields void>(evals: ProofEvaluations, f: F) ``` this probably exists, and it's flexible!
I think there's actually an quick 'n easy way to address this issue atm without resorting to macros! @mrmr1993 used a technique earlier which really inspired me and I implemented...
perhaps @duguorong009 might be interested?
btw it's this point in the protocol: the prover sends a bunch of evaluations to the verifier, and so in the non-interactive version it is akin to absorbing with the...
Ah, we decided not to go for it because we want to be able to support chunked evaluations down the line. Thanks for pushing me to write an issue on...
I doubt this would really affect any performance in a non-negligible way :o IMO we should go with the more readable/less complex route. I still did a bench, this PR:...
What's the rationale? (Mine was to improve readability.)
will do after I can get the double generic gate in