David Wong

Results 393 comments of David Wong

we might not be able to tackle this one without https://github.com/o1-labs/proof-systems/issues/432 first

I think we might be able to just write this struct as: ```rust pub struct ProofEvaluations where F: FftField { /// witness polynomials pub w: [F; COLUMNS], /// permutation polynomial...

I tried removing the Vec and just making them single elements: https://github.com/o1-labs/proof-systems/pull/680 tests don't pass due to how the PCS is written, specifically when something evaluates to zero it expects...

if you don't mind let's reopen it until I test this on the mina side, as I predict that it might be a bit painful

https://hackmd.io/i9aW1BlrSsmUJO8c9Vz3DQ

> If I understand correctly it will be a circuit to verify that some board represents a winning state, right? you could also have a circuit that takes a state,...

cc @Trivo25 that could be nice to add to the module you created :)

This issue should be about using this instead now: ```rust DensePolynomial::::from_coefficients_slice(&coeffs).evaluate(x); ```

^ when this is done, we should remove the specific handling of the public commitment https://github.com/o1-labs/proof-systems/pull/717

I think https://github.com/o1-labs/proof-systems/pull/795 was the last PR that implemented this manually, it would be great to have an API that does this and remove the "manual-ness"