proof-systems icon indicating copy to clipboard operation
proof-systems copied to clipboard

Fix pedantic lints

Open mimoo opened this issue 3 years ago • 6 comments

run:

$ cargo clippy -- -W clippy::pedantic

and fix some of the warnings

mimoo avatar Apr 07 '22 19:04 mimoo

Stale issue message

github-actions[bot] avatar Jun 07 '22 07:06 github-actions[bot]

Stale issue message

github-actions[bot] avatar Aug 08 '22 07:08 github-actions[bot]

@mimoo I will also take care of this issue.

duguorong009 avatar Sep 15 '22 16:09 duguorong009

cool thanks : ) don't hesitate to ping me here or on twitter if you have questions.

mimoo avatar Sep 15 '22 21:09 mimoo

@mimoo I think the following line is for creating the cell(s) for setting up the prover_index(prover_key). https://github.com/o1-labs/proof-systems/blob/master/circuit-construction/src/prover.rs#L175 Atm, it does have one parameter(FnOnce) for creating the default empty value.(like let v = system.var(|| panic!("fail"));) Can I update the Writer::var() trait to have no parameter? The reason is that I think it is unnecessary. Also, the parameter value is, in most cases, || panic("fail!").

duguorong009 avatar Sep 16 '22 12:09 duguorong009

@mimoo Please go for reviewing the PR #752 .

duguorong009 avatar Sep 16 '22 18:09 duguorong009

Stale issue message

github-actions[bot] avatar Nov 16 '22 07:11 github-actions[bot]