proof-systems icon indicating copy to clipboard operation
proof-systems copied to clipboard

Support empty commitments

Open mimoo opened this issue 3 years ago • 3 comments

Currently, commiting to zero polynomials will return an empty commitment:

https://github.com/o1-labs/proof-systems/blob/master/poly-commitment/src/commitment.rs#L594

from @imeckler

The way to really fix it is to add the hiding generator to all the index commitments (like 1*h so the blinding factor is known when we open)

mimoo avatar Jul 25 '22 15:07 mimoo

^ when this is done, we should remove the specific handling of the public commitment https://github.com/o1-labs/proof-systems/pull/717

mimoo avatar Aug 11 '22 20:08 mimoo

Stale issue message

github-actions[bot] avatar Oct 11 '22 07:10 github-actions[bot]

I think https://github.com/o1-labs/proof-systems/pull/795 was the last PR that implemented this manually, it would be great to have an API that does this and remove the "manual-ness"

mimoo avatar Oct 11 '22 20:10 mimoo