Michael Bromley comments

Results 750 comments of


                                            Michael Bromley

(feat): integrate Vendure Assets Picker with ProseMirror and add single image selection

Yes, it is `assets/` by default but that is configurable in the AssetServerPlugin `route` option. So not something we can safely assume. What if we set metadata on the inserted...

(feat): integrate Vendure Assets Picker with ProseMirror and add single image selection

In that case can we use a data attribute, since "internal" is not a valid attribute of `img`? Also maybe inverting it and marking "external" for outside images is better...

(feat): integrate Vendure Assets Picker with ProseMirror and add single image selection

That's very good, thank you!

feat(asset-server-plugin): optimize S3 file handling

Hi, I'm going to close this for now because the implementation was unclear to me, as per my comment above. Open to a new PR which addresses this. Thanks for...

Cannot filter collections on custom fields

Hi, are you able to reproduce this on a fresh installation? I can't reproduce locally (on master)

Sign in process not working

Hi, no I've not had a chance to look into this yet.

Failing to install dependencies.

Hi! Thanks for the report. Would you be able to try it again using the `--log-level verbose` flag and see if that gives us some useful logs?

Bug in Stripe paymentIntent.create() triggered with express checkout + normal checkout

I'm copying over some relevant parts of the conversation from the attached PR: --- > What I'm not understanding is that by default, the options.metadata function is undefined. This means...

Bug in Stripe paymentIntent.create() triggered with express checkout + normal checkout

You can use the built-in Node `crypto` module. Here's what ChatGPT suggests, which I think is along the right lines: ```ts const crypto = require('crypto'); function hashObject(object) { const hash...

Multi-Vendor setup extremely slow on loading

Hi, thanks for the detailed report. I think there are 2 separate issues here: 1. Currently the way we model channels & permissions means that when the number of channels...