Michael Bromley comments

Results 750 comments of


                                            Michael Bromley

docs: documentation for parameters in Repository, DataSource, EntityManager query methods

Very good improvement, thank you!

feat: add new undefined and null behavior flags

We discussed this PR further, including your most recent comments @sgarner in the bi-weekly maintainer meeting today. Here's a summary: - This PR is addressing a huge problem that is...

fix: solve incorrect type when dealing with value in list

Thank you for the detailed write-up and the fix! And also for your patience because it took me a while to get around to this :D

Allow overriding Importer class methods

Yes, I'd be happy to merge a PR that changes the private methods to protected if that makes it more flexible.

Accessible entity ids in relational custom fields

Hey! It took me a while to get around to this but yes, this is a very good suggestion.

Accessible entity ids in relational custom fields

This is proving much more difficult to implement correctly than I had imagined. I spent a couple of hours trying to debug the problems but I'm not there yet. The...

Accessible entity ids in relational custom fields

Moved to the v3.2 milestone because more time is needed to resolve the issues in the WIP branch.

Lint on GitHub actions

This looks good. One thing I'm wondering is whether we can move the node version matrix up to the top level to avoid repeating at every job. This will make...

Lint on GitHub actions

True, I guess we are mixing concerns here a bit. And now it caused a merge conflict 😅 I suggest let's just get the conflict resolved, merge the linting, and...

add email event UI triggers for resend option in emails

Also, make the PR against the `minor` branch please 👍