Michael Bromley

Results 750 comments of Michael Bromley

@gkielwasser good to hear that you can reproduce this locally. That's a major step towards isolating the cause so we can get it fixed. Vendure v2.2.0 made a significant update...

Great detective work. Yes, I can see that code path is absolutely un-optimized. I'm certain that this execution time can be drastically reduced. In particular this part: https://github.com/vendure-ecommerce/vendure/blob/27432c08453b56117acf3319832e6bc96939624d/packages/core/src/service/services/role.service.ts#L212-L215 is being...

Good news on this: I ran some benchmarks locally to measure the performance optimization I mention above. Using the following query to the Admin API (the exact same query run...

Hi Jack, Thanks for the report. I just tested in on the live demo instance https://remix-storefront.vendure.io/products/cordless-mouse and I can confirm the reproduction. On non-PDP pages, after deleting the cookie and...

I'm looking into the possible reasons for this like, and it looks like it was added in response to this issue: - https://github.com/vendure-ecommerce/vendure/issues/1250 That solution was for the case where...

Hi Noah, I'm not able to reproduce this currently, so I must be lacking some information. Can you give me a step-by-step sequence of actions required to reproduce. For example,...

Hi, thanks for the contribution. Is there not a version of this where we can keep the "browse all categories" but just have a link that works?

Thanks for the report. This should be a relatively straightforward one to solve. The problem is that currently neither the DefaultSearchPlugin nor the ElasticSearchPlugin are listening for the `StockMovementEvent`, which...

I upped the limit from 10 to 100. Hopefully that's enough for this case.

Hi! Thank you for taking the time to contribute. I can see you put a lot of work into this to match our existing APIs & internal patterns 👍 Regarding...